Skip to content

[WRONG BRANCH] fix(cli): preserve service command exit failures - #260

Closed
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-service-runner-exit-code-handling
Closed

[WRONG BRANCH] fix(cli): preserve service command exit failures#260
luvs01 wants to merge 1 commit into
mainfrom
codex/fix-service-runner-exit-code-handling

Conversation

@luvs01

@luvs01 luvs01 commented Aug 13, 2026

Copy link
Copy Markdown
Owner

Motivation

  • The service dispatch runner unconditionally returned 0, masking failure statuses set by serviceCommand via process.exitCode and causing ocx service to report success when the service was not actually serving.

Description

  • Make dispatchCommand propagate the service runner's observed exit status by adding a serviceCommand dependency to CliDispatchDeps and calling await deps.serviceCommand(...) from the service runner. This returns Number(process.exitCode ?? 0) instead of 0. (src/cli/dispatch.ts).
  • Wire the real serviceCommand through the top-level CLI entry so the runner receives the production implementation via deps (src/cli/index.ts).
  • Add a focused regression test asserting that a non-throwing serviceCommand that sets process.exitCode = 1 causes dispatchCommand to return 1 (tests/cli-dispatch.test.ts).

Testing

  • ✅ Ran the focused unit test: ./node_modules/.bin/bun test tests/cli-dispatch.test.ts, and the new test passed.
  • ✅ Ran type checking: ./node_modules/.bin/bun run typecheck (bun x tsc --noEmit) and it passed.
  • ⚠️ Ran the full test run ./node_modules/.bin/bun run test; the suite progressed with many passing tests but an unrelated test (CLI key-login live-update overlay preservation) timed out during the full run, so I only relied on the focused dispatch test and typecheck for verification.

Codex Task

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@luvs01, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2cc73cbe-dded-4149-bd82-5a5b5cf84d6f

📥 Commits

Reviewing files that changed from the base of the PR and between 1193075 and 7b1ea70.

📒 Files selected for processing (3)
  • src/cli/dispatch.ts
  • src/cli/index.ts
  • tests/cli-dispatch.test.ts

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the bug Something isn't working label Aug 13, 2026
@github-actions

Copy link
Copy Markdown

Deterministic PR hygiene checks passed.

@github-actions github-actions Bot changed the title fix(cli): preserve service command exit failures [WRONG BRANCH] fix(cli): preserve service command exit failures Aug 13, 2026
@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

⏳ DRAFT

  • wrong target branch (main); retarget to dev.

What to do

  • Retarget this PR to dev — all contributions go to dev.

Its title has been prefixed with [WRONG BRANCH].
This pull request was already a draft. Its draft status will be preserved after every issue above is resolved.

@github-actions
github-actions Bot marked this pull request as draft August 13, 2026 00:44
@luvs01 luvs01 closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aardvark bug Something isn't working codex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant